Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client ID to metrics #1831

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

gbanasiak
Copy link
Contributor

When analyzing Rally metrics with runs with multiple clients it is impossible to filter for a specific client ID. This PR adds new meta.client_id field to every metric record which can be attributed to a specific client, i.e. is not aggregated like throughput.

@gbanasiak gbanasiak added the enhancement Improves the status quo label Feb 20, 2024
@gbanasiak gbanasiak requested a review from a team February 20, 2024 11:34
Copy link
Contributor

@favilo favilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbanasiak gbanasiak merged commit 611d2df into elastic:master Mar 14, 2024
15 checks passed
@gbanasiak gbanasiak deleted the client-id-in-metrics branch March 14, 2024 13:46
@gareth-ellis gareth-ellis added this to the 2.11 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants